[GitHub] [pinot] mathieudruart commented on a diff in pull request #9859: Use Pulsar AdminClient to delete unused subscriptions

[GitBox <gi...@apache.org>]

mathieudruart commented on code in PR #9859:
URL: https://github.com/apache/pinot/pull/9859#discussion_r1031698031


##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMetadataProvider.java:
##########
@@ -156,11 +174,21 @@ public List<PartitionGroupMetadata> computePartitionGroupMetadata(String clientI
       LOGGER.warn("Error encountered while calculating pulsar partition group metadata: " + e.getMessage(), e);
     } finally {
       closeConsumer(consumer);
+      deleteSubscription(_topic, subscription);
     }
 
     return newPartitionGroupMetadataList;
   }
 
+  private void deleteSubscription(String topicName, String subscription) {
+    try {
+      _pulsarAdminClient.topics().deleteSubscription(topicName, subscription);

Review Comment:
   I saw that it was possible to create lightweight subscriptions using non durable subscription mode, it may be a simpler / more efficient solution to solve the problem (the subscription is never persisted):
   
           Consumer<byte[]> consumer = pulsarClient.newConsumer()
                   .topic("my-topic")
                   .subscriptionName("my-sub")
                   .subscriptionMode(SubscriptionMode.NonDurable)
                   .subscribe();



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org