You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladimirg-db (via GitHub)" <gi...@apache.org> on 2024/05/01 09:26:32 UTC

[PR] [SPARK-48072][SQL] Improve SQLQuerySuite test output [spark]

vladimirg-db opened a new pull request, #46318:
URL: https://github.com/apache/spark/pull/46318

   ### What changes were proposed in this pull request?
   Improve test output for the actual query to be printed alongside of expected
   
   
   ### Why are the changes needed?
   To reduce confusion later
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   `testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-47939`
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output [spark]

Posted by "vladimirg-db (via GitHub)" <gi...@apache.org>.
vladimirg-db commented on PR #46318:
URL: https://github.com/apache/spark/pull/46318#issuecomment-2089979391

   Yes, @dongjoon-hyun, my intent was to add a small improvement after the [SPARK-47939](https://issues.apache.org/jira/browse/SPARK-47939), which was resolved by my PR recently. However you are right - I've added couple of similar improvements to this PR. Thank you for the advice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #46318:
URL: https://github.com/apache/spark/pull/46318#discussion_r1586626193


##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4750,12 +4750,13 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
   }
 
   test("SPARK-47939: Explain should work with parameterized queries") {
-    def checkQueryPlan(df: DataFrame, plan: String): Unit = assert(
-      df.collect()
+    def checkQueryPlan(df: DataFrame, plan: String): Unit = {

Review Comment:
   Well, this is only for this single test case instead of the whole `SQLQuerySuite`. It would be great if the PR title could describe more precisely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output - use `===` instead of `sameElements` for Arrays [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #46318: [SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output - use `===` instead of `sameElements` for Arrays
URL: https://github.com/apache/spark/pull/46318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org