You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/08/18 21:48:33 UTC

[GitHub] [systemds] phaniarnab commented on pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.

phaniarnab commented on PR #1671:
URL: https://github.com/apache/systemds/pull/1671#issuecomment-1220000817

   We didn't encounter this issue in the local transformencode simply because we don't call getColumnData there.
   In the encoders we access cell-wise (getDouble) and the objectToDouble method rightly handles FP32 @mboehm7.
   Thanks @paginabianca for even fixing the getInMemorySize method. Not supporting FP32 there leads to wrong size calculation and in turn array out-of-bound error during serializing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org