[GitHub] [iceberg] RussellSpitzer commented on pull request #2479: Spark: Remove the shading of org.codehaus.jackson.

[GitBox <gi...@apache.org>]

RussellSpitzer commented on pull request #2479:
URL: https://github.com/apache/iceberg/pull/2479#issuecomment-819735306


   So I have no problem here as long as we want this to be the version of jackson from Spark. If we want to keep shading I also think it's fine to shade Avro's Jackson separately then remove it's exclusion. 
   
   IE Before
   
   Parquet has shaded Jackson
   Avro changed references of jackson to point to the Parquet shaded lib
   We exclude Jackson from avro runtime so it won't be included in the in fat jar and we instead rely on the jars appearing from the Parquet shaded libs
   
   
   Now
   
   Parquet has no shaded jackson
   We can relocate Avro's jackson references 
   Don't exclude jackson from Avro runtime and shade it
   
   
   That said i'm still not sure how important shading jackson is in this context so the solution of just pulling the relocation may be fine as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org