[GitHub] [pulsar] Jason918 commented on a change in pull request #12990: Fix unable to subscribe non-persistent topics via regex.

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #12990:
URL: https://github.com/apache/pulsar/pull/12990#discussion_r757736235



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
##########
@@ -1167,8 +1167,7 @@ public ServiceUnitId getServiceUnitId(TopicName topicName) throws Exception {
                                 pulsar.getBrokerService().getMultiLayerTopicMap().get(namespaceName.toString())
                                         .forEach((__, bundle) -> {
                                             bundle.forEach((topicName, topic) -> {
-                                                if (topic instanceof NonPersistentTopic
-                                                        && ((NonPersistentTopic) topic).isActive()) {

Review comment:
       Have you checked why do we added `isActive` check in the first place?
   Will it affect other use cases if we remove this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org