You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:46:17 UTC

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #6066: [TIR][Transform] HoistIfThenElse added

MarisaKirisame commented on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-665762811


   0: I dont think a pass have to handle all cases for it to be merged. We can improve upon it incrementally.
   1: About loop unswitching, detecting invariant is very hard. But we can simply approximate by detecting expr that didnt have any vars change in the loop. There is rice theorem, so all solution will not be perfect, and we should do the least amount of work that get us good enough performance.
   2: you should just build a datastructure/helper function such as boundvar/freevar to help. I dont found dealing with scope too complex in the pass I had written. If you had more specific question/objection please bring it up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org