You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (Created) (JIRA)" <ji...@apache.org> on 2011/09/27 18:10:12 UTC
[jira] [Created] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
--------------------------------------------------------------------------------
Key: PIVOT-795
URL: https://issues.apache.org/jira/browse/PIVOT-795
Project: Pivot
Issue Type: Improvement
Components: wtk-terra
Affects Versions: 2.0.1
Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Assignee: Roger Whitcomb
Priority: Trivial
Fix For: 2.0.1
I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-795:
---------------------------------
Attachment: filebrowserskin.patch
I think this patch will do the trick.
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: filebrowserskin.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Sandro Martini (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-795:
---------------------------------
Attachment: FileBrowserWithCharsetTest.java
Roger, this is a modified version of your test class (but now it's even a minimal test application for this feature).
Let me know if it's good for you to be included with your patch, and if you want commit it, or tell me.
Bye
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharset.java, FileBrowserWithCharsetTest.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-795:
---------------------------------
Attachment: FileBrowserWithCharset.java
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharset.java, filebrowserskin.patch, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb resolved PIVOT-795.
----------------------------------
Resolution: Fixed
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharsetTest.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-795:
---------------------------------
Attachment: filebrowserskin2.patch
After thrashing around a lot (mostly due to my lack of understanding of how to subclass an existing skin) I have this patch (filebrowserskin2.patch) working now in my application.
What does everyone think? Basically I added an "addComponent" method so that the internals of the skin wouldn't have to be exposed. It can be used this way (see attached FileBrowserWithCharset.java).
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharset.java, filebrowserskin.patch, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124331#comment-13124331 ]
Roger Whitcomb commented on PIVOT-795:
--------------------------------------
Committed both the code change and the test case code: 1181083 and 1181089.
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharsetTest.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-795:
---------------------------------
Attachment: (was: filebrowserskin.patch)
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharset.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Sandro Martini (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119676#comment-13119676 ]
Sandro Martini commented on PIVOT-795:
--------------------------------------
Hi Roger,
to me the patch seem good, so if gthere aren't objections (until tomorrow) I'd say you can apply it.
Only one thing, I see that the other file in attach is not granted for inclusion (it has your domain, I understand), but I think it would be good to create a sample Test minimal application (under tests/src/org.apache.pivot.tests) to show it, right ? Tell me.
Bye
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharset.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-795:
---------------------------------
Attachment: (was: FileBrowserWithCharset.java)
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharsetTest.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-795) Add access in
TerraFileBrowserSheetSkin to allow additional fields in the dialog
Posted by "Roger Whitcomb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126994#comment-13126994 ]
Roger Whitcomb commented on PIVOT-795:
--------------------------------------
Committed 1183126 as a refinement -- moved the additional components up to be above the OK/Cancel buttons so it looks more like a part of the dialog.
> Add access in TerraFileBrowserSheetSkin to allow additional fields in the dialog
> --------------------------------------------------------------------------------
>
> Key: PIVOT-795
> URL: https://issues.apache.org/jira/browse/PIVOT-795
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: features
> Fix For: 2.0.1
>
> Attachments: FileBrowserWithCharsetTest.java, filebrowserskin2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to be able to (for instance) add a ListButton field to the Open File dialog to specify a character set encoding. In order to do this, I think the minimal support would be making the main TablePane of the dialog available as a protected field so a subclass of TerraFileBrowserSheetSkin could access it to add additional fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira