You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by grandinj <gi...@git.apache.org> on 2018/01/30 15:25:21 UTC
[GitHub] activemq-artemis pull request #1824: fix some eclipse raw types warnings
GitHub user grandinj opened a pull request:
https://github.com/apache/activemq-artemis/pull/1824
fix some eclipse raw types warnings
in the process improving the type signature of getPrincipalsInRole, which was returning a Set<RolePrincipal>, but was adding things from createGroupPrincipal to the set, and createGroupPrincipal can return an object that only implements Principal, not RolePrincipal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grandinj/activemq-artemis eclipse_raw_types_warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1824
----
commit 9c91f85e427d48d1ee32e454de2baa677aec8b4a
Author: Noel Grandin <no...@...>
Date: 2018-01-30T15:24:05Z
fix some eclipse raw types warnings
in the process improving the type signature of getPrincipalsInRole, which was returning a Set<RolePrincipal>, but was adding things from createGroupPrincipal to the set, and createGroupPrincipal can return an object that only implements Principal, not RolePrincipal.
----
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
@grandinj looks fine to me also, could you just do a forced push on your PR to make the PR build kick off again, seems the PR build didn't complete. Also whilst at it, could you either create a JIRA and put a JIRA number in the commit title, or add NO-JIRA to it, im fine with either as this is more about just code formatting.
---
[GitHub] activemq-artemis pull request #1824: fix some eclipse raw types warnings
Posted by grandinj <gi...@git.apache.org>.
Github user grandinj closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1824
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by grandinj <gi...@git.apache.org>.
Github user grandinj commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
Note that I already have an Apache committer license thingy on file (I was a maintainer on Apache Pivot)
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
@grandinj i think the PR build issues are resolved, sorry if its a pain, could you just force update to make it trigger again?
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by grandinj <gi...@git.apache.org>.
Github user grandinj commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
hmm, I've updated the commit title,
and I've done a forced update (after doing a merge and realising I was on the wrong track), but it doesn't look like that triggered a build?
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
looks fine.
---
[GitHub] activemq-artemis issue #1824: fix some eclipse raw types warnings
Posted by grandinj <gi...@git.apache.org>.
Github user grandinj commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
really sorry, but I've already blown away my environment, might as well just close this, not that important
---