You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "LetLetMe (via GitHub)" <gi...@apache.org> on 2024/11/14 08:56:59 UTC
[I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
LetLetMe opened a new issue, #8924:
URL: https://github.com/apache/rocketmq/issues/8924
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
### Runtime platform environment
nothing
### RocketMQ version
nothing
### JDK Version
nothing
### Describe the Bug

The latest develop branch includes a method signature change that introduces a checked exception, requiring modifications across all downstream dependencies. We should discuss whether to maintain this change or roll it back temporarily, with the option to implement it consistently in a future release.
最新的develop代码中该方法签名进行了修改,抛出了checked exception,导致下游调用方都需要进行改造,该改造是否需要讨论下?看看是保留还是先回滚,等后续版本统一修改。
### Steps to Reproduce
nothing
### What Did You Expect to See?
nothing
### What Did You See Instead?
nothing
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #8924:
URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-3537149291
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #8924:
URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-3555154878
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #8924:
URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-2478245120
1. Change an existing method beheavier violates the open closed principle. Moreover, if getMaxOffset method is modified, getMinOffset should also be correspondingly adjusted. Additionally, mixing the LMQ handling logic into the existing logic without proper abstraction is not elegant.
2. It is reasonable to pay attention to and discuss this commit before the next release. As is well known, it may cost months for a Linux kernal fix to be merged into the mainline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #8924: [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x
URL: https://github.com/apache/rocketmq/issues/8924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "LetLetMe (via GitHub)" <gi...@apache.org>.
LetLetMe commented on issue #8924:
URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-2475785168
@lizhimins @lizhanhui @lollipopjin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss] Keep the method signature of getMaxOffsetInQueue() compatible across version 5.3.x [rocketmq]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on issue #8924:
URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-2476002598
1. It's reasonable to have this method raise Exception if it cannot accomplish its job and does not have enough knowledge to handle the failure properly;
2. MessageStore cannot always be successful;
3. If your Magic MessageStore Implementation is capable of being always successful, your job to adapt to this change should be trivial, catch and throw a runtime one or silent it;
4. This is not a public API change beyond broker role, aka, this change does not affect clients, admin tools, etc.
5. If you guys are worried, why not keep an eye on the pull request earlier, the pull request stayed open for several days;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org