[GitHub] [spark] HyukjinKwon commented on a change in pull request #31577: [SPARK-34454][SQL] Mark legacy SQL configs as internal

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31577:
URL: https://github.com/apache/spark/pull/31577#discussion_r578299680



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -451,4 +451,14 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
     val e2 = intercept[ParseException](sql("set time zone interval 19 hours"))
     assert(e2.getMessage contains "The interval value must be in the range of [-18, +18] hours")
   }
+
+  test("SPARK-34454: configs from the legacy namespace should be internal") {
+    val nonInternalLegacyConfigs = spark.sessionState.conf.getAllDefinedConfs
+      .filter { case (key, _, _, _) => key.contains(".legacy.") }

Review comment:
       Are there any non-`spark.sql.legacy` legacy conf in Apache Spark codebase?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org