You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "abhioncbr (via GitHub)" <gi...@apache.org> on 2023/06/30 02:48:37 UTC
[GitHub] [pinot] abhioncbr opened a new pull request, #11009: [multistage]: Better SQL Syntax Error Messages
abhioncbr opened a new pull request, #11009:
URL: https://github.com/apache/pinot/pull/11009
As per the [issue discussion](https://github.com/apache/pinot/issues/10921), changing it to `SqlCompilationException` to get the error message indicating the problem. With the changes in this PR, the message on the UI for non-compilable SQL query looks like this
<img width="1122" alt="Screen Shot 2023-06-29 at 10 41 44 PM" src="https://github.com/apache/pinot/assets/1076944/af30467e-e8f0-4bff-8be4-0ee3bbe26aa7">
cc: @walterddr @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #11009: [multistage]: Better SQL Syntax Error Messages
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #11009:
URL: https://github.com/apache/pinot/pull/11009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ege-st commented on pull request #11009: [multistage]: Better SQL Syntax Error Messages
Posted by "ege-st (via GitHub)" <gi...@apache.org>.
ege-st commented on PR #11009:
URL: https://github.com/apache/pinot/pull/11009#issuecomment-1614822293
@abhioncbr this is great, thanks!
@walterddr do we want to fix error messages in the V1 query engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #11009: [multistage]: Better SQL Syntax Error Messages
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #11009:
URL: https://github.com/apache/pinot/pull/11009#issuecomment-1615098549
> @abhioncbr this is great, thanks!
>
> @walterddr do we also want to fix error messages in the V1 query engine?
I believe this change is on the common code path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11009: [multistage]: Better SQL Syntax Error Messages
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11009:
URL: https://github.com/apache/pinot/pull/11009#issuecomment-1614063062
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11009?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11009](https://app.codecov.io/gh/apache/pinot/pull/11009?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d247b5f) into [master](https://app.codecov.io/gh/apache/pinot/commit/a2086072545fc67a35f5d6756c3b9efc97d15641?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a208607) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11009 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2189 2137 -52
Lines 117993 115501 -2492
Branches 17852 17566 -286
=========================================
Hits 137 137
+ Misses 117836 115344 -2492
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `0.11% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/11009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...t/controller/api/resources/PinotQueryResource.java](https://app.codecov.io/gh/apache/pinot/pull/11009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90UXVlcnlSZXNvdXJjZS5qYXZh) | `0.00% <ø> (ø)` | |
... and [123 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11009/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org