[GitHub] chaoyli commented on a change in pull request #575: realize rowset remove api

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #575: realize rowset remove api
URL: https://github.com/apache/incubator-doris/pull/575#discussion_r251315388
 
 

 ##########
 File path: be/src/olap/rowset/alpha_rowset.cpp
 ##########
 @@ -75,6 +90,10 @@ RowsetMetaSharedPtr AlphaRowset::rowset_meta() const {
 }
 
 void AlphaRowset::set_version(Version version) {
+    if (_removed) {
 
 Review comment:
   I think Rowset is already removed in memory structure synchronously if _removed is true.
   So this judgement will be redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org