You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "m-gorecki (via GitHub)" <gi...@apache.org> on 2024/02/23 09:02:31 UTC
[PR] newt: Fix shallow upgrade with specific commit version [mynewt-newt]
m-gorecki opened a new pull request, #543:
URL: https://github.com/apache/mynewt-newt/pull/543
Upgrading project using shallow option was causing an error if repository version was specified as specific commit. Because this specific commit could not yet be fetched it could not be found during version validation.
Now if shallow upgrade is being performed, instead of returning an error immediately after commit was not found, we first try to fetch the specified commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Fix shallow upgrade with specific commit version [mynewt-newt]
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek commented on code in PR #543:
URL: https://github.com/apache/mynewt-newt/pull/543#discussion_r1502403993
##########
newt/repo/version.go:
##########
@@ -126,6 +126,15 @@ func (r *Repo) VersionIsValid(ver newtutil.RepoVersion) bool {
}
cs, _ := r.downloader.CommitsFor(r.Path(), ver.Commit)
+
+ // For shallow copy commit might not be fetched yet
Review Comment:
this could be actually done regardless of whether repo is shallow or now
the same problem exists if user specifies a commit that is not preset on any remote branch, e.g. a sha for PR head
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Fix shallow upgrade with specific commit version [mynewt-newt]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #543:
URL: https://github.com/apache/mynewt-newt/pull/543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org