You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/09/10 19:48:22 UTC
[kudu-CR] [WIP] Add helper macro for tool invocations
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11411
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
[WIP] Add helper macro for tool invocations
Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER
WIP because the macro is a little clunky and I'd like input from wiser
C++ people. Once the macro is finalized. there are a lot more places to
update to use the new macro.
Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 31 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/1
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add helper macro for tool invocations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: Add helper macro for tool invocations
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc@140
PS3, Line 140: "kudu",
I think this should be
ASSERT_TOOL_OK("cluster", "ksck", master_addrs);
right?
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Sep 2018 04:08:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11411
to look at the new patch set (#3).
Change subject: Add helper macro for tool invocations
......................................................................
Add helper macro for tool invocations
Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER
Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/3
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@147
PS1, Line 147: #define ASSERT_TOOL_OK(tool_cmd) do { \
: const vector<string>& _args = (tool_cmd); \
Another way might be using variadic macros:
#define ASSERT_TOOL_OK(...) do { \
const vector<string>& _args{__VA_ARGS__}; \
And then in the code:
ASSERT_TOOL_OK(
"tablet",
"change_config",
"remove_replica",
cluster_->master()->bound_rpc_addr().ToString(),
tablet_id_,
new_node->uuid());
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 22:45:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@142
PS1, Line 142: // Note the type specifier and extra parentheses. Unfortunately, these are
: // necessary for the macro to parse correctly.
> Would you still need that if tool_cmd was embedded in the call to RunKuduTo
Unfortunately, no. It doesn't allow the parentheses or the 'vector<string>' to be dropped.
Seems it needs the parentheses because C++ requires them around initializer lists when the list is a macro argument.
The type specifier is more ad hoc...if I don't include it, from the compiler error message it seems that it splits up the initializer list into strings, e.g.
../../src/kudu/tools/kudu-admin-test.cc:227:5: warning: expression result unused [-Wunused-value]
"tablet",
^~~~~~~~
../../src/kudu/tools/kudu-admin-test.cc:149:22: note: expanded from macro 'ASSERT_TOOL_OK'
const Status& _s = RunKuduTool(tool_cmd, &_out, &_err); \
^~~~~~~~~~~
../../src/kudu/tools/tool_test_util.h:37:8: note: candidate function not viable: no known conversion from 'const char *' to 'const std::vector<std::string>' (aka 'const vector<basic_string<char, char_traits<char>, allocator<char> > >') for 1st argument
Status RunKuduTool(const std::vector<std::string>& args,
^
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 20:42:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: Add helper macro for tool invocations
......................................................................
Add helper macro for tool invocations
Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER
Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Reviewed-on: http://gerrit.cloudera.org:8080/11411
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11411
to look at the new patch set (#2).
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
[WIP] Add helper macro for tool invocations
Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER
WIP because the macro is a little clunky and I'd like input from wiser
C++ people. Once the macro is finalized. there are a lot more places to
update to use the new macro.
Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/2
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@142
PS1, Line 142: // Note the type specifier and extra parentheses. Unfortunately, these are
: // necessary for the macro to parse correctly.
Would you still need that if tool_cmd was embedded in the call to RunKuduTool rather than evaluated up-front?
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 20:31:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@147
PS1, Line 147: #define ASSERT_TOOL_OK(tool_cmd) do { \
: const vector<string>& _args = (tool_cmd); \
> Another way might be using variadic macros:
That works! Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 00:05:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] Add helper macro for tool invocations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@142
PS1, Line 142: // Note the type specifier and extra parentheses. Unfortunately, these are
: // necessary for the macro to parse correctly.
> Unfortunately, no. It doesn't allow the parentheses or the 'vector<string>'
Gotcha. Try Alexey; he's got a lot of C++ arcane knowledge.
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 20:46:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add helper macro for tool invocations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: Add helper macro for tool invocations
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 17:27:18 +0000
Gerrit-HasComments: No
[kudu-CR] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11411
to look at the new patch set (#4).
Change subject: Add helper macro for tool invocations
......................................................................
Add helper macro for tool invocations
Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but
it results in lousy test failure output:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and
stderr of a `kudu` tool invocation:
../../src/kudu/tools/kudu-admin-test.cc:235: Failure
Failed
Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1
stdout:
stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true
Invalid argument: Unrecognized peer type: FOOVOTER
Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 47 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/4
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add helper macro for tool invocations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: Add helper macro for tool invocations
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/11411/3/src/kudu/tools/kudu-admin-test.cc@140
PS3, Line 140: "kudu",
> I think this should be
Done
--
To view, visit http://gerrit.cloudera.org:8080/11411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07
Gerrit-Change-Number: 11411
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 17:26:27 +0000
Gerrit-HasComments: Yes