You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2017/11/08 10:17:41 UTC

[GitHub] spark pull request #19459: [SPARK-20791][PYSPARK] Use Arrow to create Spark ...

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19459#discussion_r149626358
  
    --- Diff: python/pyspark/serializers.py ---
    @@ -213,7 +213,15 @@ def __repr__(self):
             return "ArrowSerializer"
     
     
    -def _create_batch(series):
    +def _create_batch(series, copy=False):
    --- End diff --
    
    Do we need `copy` here?
    I might miss something but looks like all occurrence of `copy=copy` in this method are always copied by `s.fillna(0)` in advance so we don't need to use `copy=True`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org