You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/11/03 21:04:51 UTC

[kudu-CR] [docker] Fix build when using default base OS

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16694


Change subject: [docker] Fix build when using default base OS
......................................................................

[docker] Fix build when using default base OS

When using the default base OS the string is not utf8 type and `isnumeric`
is not defined. This small fix changes to `isdigit` which works with all
python strings.

Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
---
M docker/docker-build.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/16694/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Gerrit-Change-Number: 16694
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [docker] Fix build when using default base OS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16694 )

Change subject: [docker] Fix build when using default base OS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Gerrit-Change-Number: 16694
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 11:32:32 +0000
Gerrit-HasComments: No

[kudu-CR] [docker] Fix build when using default base OS

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16694 )

Change subject: [docker] Fix build when using default base OS
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16694/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16694/1//COMMIT_MSG@9
PS1, Line 9: not utf8 type
> just curious, why is it not utf8 type?
Python string constants aren't utf-8 by default.



-- 
To view, visit http://gerrit.cloudera.org:8080/16694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Gerrit-Change-Number: 16694
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 14:01:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docker] Fix build when using default base OS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16694 )

Change subject: [docker] Fix build when using default base OS
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16694/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16694/1//COMMIT_MSG@9
PS1, Line 9: not utf8 type
just curious, why is it not utf8 type?



-- 
To view, visit http://gerrit.cloudera.org:8080/16694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Gerrit-Change-Number: 16694
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 11:33:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docker] Fix build when using default base OS

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16694 )

Change subject: [docker] Fix build when using default base OS
......................................................................

[docker] Fix build when using default base OS

When using the default base OS the string is not utf8 type and `isnumeric`
is not defined. This small fix changes to `isdigit` which works with all
python strings.

Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Reviewed-on: http://gerrit.cloudera.org:8080/16694
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M docker/docker-build.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81069970caabce1c7b9e0cdabaee403fdf921bad
Gerrit-Change-Number: 16694
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)