[GitHub] carryxyh commented on a change in pull request #2322: [DUBBO-2321]Provider "async = true" need to be remove from url when register to registry#2321

[GitBox <gi...@apache.org>]

carryxyh commented on a change in pull request #2322: [DUBBO-2321]Provider "async = true" need to be remove from url when register to registry#2321
URL: https://github.com/apache/incubator-dubbo/pull/2322#discussion_r214675041
 
 

 ##########
 File path: dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
 ##########
 @@ -231,7 +240,8 @@ private URL getRegisteredProviderUrl(final Invoker<?> originInvoker) {
                 .removeParameter(QOS_PORT)
                 .removeParameter(ACCEPT_FOREIGN_IP)
                 .removeParameter(VALIDATION_KEY)
-                .removeParameter(INTERFACES);
+                .removeParameter(INTERFACES)
+                .removeParameters(asyncKey);
 
 Review comment:
   Hi, 
   I saw your ISSUE, I think async should be registered to the registry so that we can see if the provider supports asynchronous on dubbo-ops.
   IMO, the better way is that the Consumer side does not use the Provider-side async, which can be analogous to the timeout override strategy in Consumer side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org