You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/01 02:43:44 UTC

[GitHub] [incubator-superset] venter-zhu opened a new pull request #9428: [fix]some translation not work better

venter-zhu opened a new pull request #9428: [fix]some translation not work better
URL: https://github.com/apache/incubator-superset/pull/9428
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   when change the language,the front translation can not work
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before             |  After the chinese| After the russian
   :-------------------------:|:-------------------------:|:-------------------------:|
   ![before](https://user-images.githubusercontent.com/13394441/78093353-99f6c900-7404-11ea-8c9b-05ef05012df5.png)  |  ![after2](https://user-images.githubusercontent.com/13394441/78093369-a549f480-7404-11ea-9a8d-7650fd78aa87.png)|![after](https://user-images.githubusercontent.com/13394441/78093402-b4c93d80-7404-11ea-9dfe-d0f37f8094c1.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9428: [fix]some translation not work better

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9428: [fix]some translation not work better
URL: https://github.com/apache/incubator-superset/pull/9428#issuecomment-606997145
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=h1) Report
   > Merging [#9428](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a9ff51bd6133559c71a43318f46c80e0fe913618&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9428/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9428   +/-   ##
   =======================================
     Coverage   59.01%   59.01%           
   =======================================
     Files         378      378           
     Lines       12167    12167           
     Branches     3008     3008           
   =======================================
     Hits         7180     7180           
     Misses       4806     4806           
     Partials      181      181           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=footer). Last update [a9ff51b...f413928](https://codecov.io/gh/apache/incubator-superset/pull/9428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 merged pull request #9428: [fix]some translation not work better

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9428: [fix]some translation not work better
URL: https://github.com/apache/incubator-superset/pull/9428
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org