[GitHub] [pulsar] wangjialing218 edited a comment on pull request #13204: support limit message size produced by protocol handlers by maxMessag…

[GitBox <gi...@apache.org>]

wangjialing218 edited a comment on pull request #13204:
URL: https://github.com/apache/pulsar/pull/13204#issuecomment-997547996


   @hangc0276 You may mentioned #7406, which introduced the throttle policy by io thread.
   This PR make more effective use of memory, and could also improve the points mentioned in #7406, beside this:
   -- There is a delay for detecting the memory over-commit, due to the background task running periodically
   As idle connection will not call `LoggAdder.add`, we only need to count up the bytes from active connection in `LoggAdder.sum`. We could do the detecting more frequently to avoid OOM, such as 10ms per time.
   
   > IMO, it's better to throttle in KOP side, do you have any other ideas?
   
   For this point, we could make sure broker and KoP share the IO thread pool, and do same throttle policy by io thread in KoP side.  @BewareMyPower
   I notice there is a configuration `useSeparateThreadPoolForProtocolHandlers` with default value true. I wonder if there is any disadvantage when set this configuration false.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org