You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "emmenlau (via GitHub)" <gi...@apache.org> on 2023/10/11 14:55:51 UTC
[PR] Very minor code cleanup (whitespace changes only) [thrift]
emmenlau opened a new pull request, #2866:
URL: https://github.com/apache/thrift/pull/2866
This commit makes very minor code cleanup improvements to file `lib/cpp/test/concurrency/Tests.cpp`, and adds a missing include.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Very minor code cleanup (whitespace changes only) [thrift]
Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau merged PR #2866:
URL: https://github.com/apache/thrift/pull/2866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Very minor code cleanup (whitespace changes only) [thrift]
Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau commented on PR #2866:
URL: https://github.com/apache/thrift/pull/2866#issuecomment-1759536931
No build problems or errors are related to this change. Failing tests already failed before:
- https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48258441/job/usyl6q6av8ks9rib
- https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48258441/job/2jvgkyk39gv9rxwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org