You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/09/22 12:42:37 UTC

[GitHub] [submarine] cdmikechen commented on a diff in pull request #998: SUBMARINE-1329. Improve test coverage of submarine.artifacts module

cdmikechen commented on code in PR #998:
URL: https://github.com/apache/submarine/pull/998#discussion_r977606391


##########
submarine-sdk/pysubmarine/pytest.ini:
##########
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   If we package `submarine-sdk`, will this file be included as well? Do we need to exclude this file in setup.py? like this:
   ```python
   setup(
       name="apache-submarine",
       ****
       packages=find_packages(exclude=["tests", "tests.*","pytest.ini"]),
       ****
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org