You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:52 UTC

[GitHub] [flink] godfreyhe commented on a change in pull request #13837: [FLINK-19874][table-planner-blink] Apply JoinDeriveNullFilterRule after join reorder

godfreyhe commented on a change in pull request #13837:
URL: https://github.com/apache/flink/pull/13837#discussion_r515775965



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala
##########
@@ -222,10 +222,13 @@ object FlinkBatchRuleSets {
   val JOIN_COND_EQUAL_TRANSFER_RULES: RuleSet = RuleSets.ofList((
     RuleSets.ofList(JoinConditionEqualityTransferRule.INSTANCE).asScala ++
       PREDICATE_SIMPLIFY_EXPRESSION_RULES.asScala ++
-      FILTER_RULES.asScala ++
-      RuleSets.ofList(JoinDeriveNullFilterRule.INSTANCE).asScala
+      FILTER_RULES.asScala
     ).asJava)
 
+  val JOIN_NULL_FILTER_RULES: RuleSet = RuleSets.ofList(

Review comment:
       It's better `JOIN_PREDICATE_REWRITE_RULES` could reuse this rule set




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org