You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:04:05 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #599: Fix page navigation error when delete template.
utchoang opened a new pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599
Open for https://github.com/apache/cloudstack-primate/issues/598
@rhtyd cc @svenvogel I've completed this task. Please review it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677463276
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#discussion_r473788523
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -266,7 +266,10 @@ export default {
jobId,
successMethod: result => {
if (singleZone) {
- this.$router.go(-1)
+ const isResourcePage = !!(this.$route.params && this.$route.params.id)
Review comment:
@utchoang `!!` Double not ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677462989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677494057
@rhtyd Good to go! Thanks @utchoang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677468956
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/599 (JID-3282)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #599: Fix page navigation error when delete template.
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #599:
URL: https://github.com/apache/cloudstack-primate/pull/599#discussion_r473804872
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -266,7 +266,10 @@ export default {
jobId,
successMethod: result => {
if (singleZone) {
- this.$router.go(-1)
+ const isResourcePage = !!(this.$route.params && this.$route.params.id)
Review comment:
@davidjumani I've removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org