You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/28 06:08:16 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…

danny0405 commented on code in PR #6920:
URL: https://github.com/apache/hudi/pull/6920#discussion_r1033156381


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -474,7 +474,7 @@ private HoodieTimeline getArchivedReadTimeline(HoodieTableMetaClient metaClient,
    * @param issuedInstant  The last issued instant that has already been delivered to downstream
    * @return the filtered hoodie instants
    */
-  private List<HoodieInstant> filterInstantsWithRange(
+  public List<HoodieInstant> filterInstantsWithRange(

Review Comment:
   Add the tag `@VisibleForTesting`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org