[GitHub] [cordova-plugin-screen-orientation] breautek opened a new pull request #79: ci: Upgrade build tools to use modern tooling & device profiles

[GitBox <gi...@apache.org>]

breautek opened a new pull request #79:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/79


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   CI
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Progresses https://github.com/apache/cordova/issues/223
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Updates CI configs to use modern tooling and device profiles.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Ran `npm test`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-screen-orientation] breautek commented on pull request #79: ci: Upgrade build tools to use modern tooling & device profiles

[GitBox <gi...@apache.org>]

breautek commented on pull request #79:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/79#issuecomment-787476530


   Test is failing on desktop browsers for this reason: https://github.com/apache/cordova-plugin-screen-orientation/issues/35#issuecomment-658536587
   
   Desktop browsers now implements the APIs, so we use them, but they will reject as you can't lock an orientation on desktop.
   
   On rejection, we will fallback to a cordova bridge, but we don't actually have a browser implementation for the fallback, thus resulting to `cordova.js:1001 Error: exec proxy not found for :: CDVOrientation :: screenOrientation` message.
   
   It sounds like these tests are going to have to be spied on to simulate, but we also should probably return a meaningful message when running in an environment that doesn't actually support orientation locking.
   
   I haven't tested yet, but I assume this works as intended in the mobile browser.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org