[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2000: HDDS-4915. [SCM HA Security] Integrate CertClient.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2000:
URL: https://github.com/apache/ozone/pull/2000#discussion_r593009482



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
##########
@@ -167,8 +168,16 @@ public OzoneContainer(
     blockDeletingService =
         new BlockDeletingService(this, svcInterval.toMillis(), serviceTimeout,
             TimeUnit.MILLISECONDS, config);
+
+    List<X509Certificate> x509Certificates = new ArrayList<>();
+    if (certClient != null) {
+      x509Certificates.add(certClient.getCACertificate());
+      if (certClient.getRootCACertificate() != null) {

Review comment:
       This is not making an RPC Call, it is getting from in-mem map.
   
   (It gets Root Cert when it makes a call getDatanodeCertificate)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org