[GitHub] [nifi-minifi-cpp] achristianson commented on a change in pull request #603: MINIFICPP-929 mmap

[GitBox <gi...@apache.org>]

achristianson commented on a change in pull request #603: MINIFICPP-929 mmap
URL: https://github.com/apache/nifi-minifi-cpp/pull/603#discussion_r298711152
 
 

 ##########
 File path: extensions/rocksdb-repos/DatabaseContentRepository.cpp
 ##########
 @@ -38,8 +39,8 @@ bool DatabaseContentRepository::initialize(const std::shared_ptr<minifi::Configu
   }
   rocksdb::Options options;
   options.create_if_missing = true;
-  options.use_direct_io_for_flush_and_compaction = true;
-  options.use_direct_reads = true;
+//  options.use_direct_io_for_flush_and_compaction = true;
+//  options.use_direct_reads = true;
 
 Review comment:
   I didn't mean to commit this part, but I will note: on my machine this was causing build failure, even on master, so we probably will need to look at this separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services