[GitHub] [spark] gengliangwang commented on a change in pull request #32157: [SPARK-35052][SQL] Use static bits for AttributeReference and Literal

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #32157:
URL: https://github.com/apache/spark/pull/32157#discussion_r613792371



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -307,6 +335,14 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
 
   private def timeZoneId = DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone)
 
+  protected override def getDefaultTreePatternBits: BitSet = {

Review comment:
       Let's override `lazy val treePatternBits` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org