You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/16 09:14:28 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5403: fixing template argument if not specify values
codecov-io edited a comment on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629614815
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=h1) Report
> Merging [#5403](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `69.55%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5403/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5403 +/- ##
==========================================
+ Coverage 66.44% 66.74% +0.29%
==========================================
Files 1075 1091 +16
Lines 54773 55785 +1012
Branches 8168 8365 +197
==========================================
+ Hits 36396 37235 +839
- Misses 15700 15797 +97
- Partials 2677 2753 +76
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `75.82% <0.00%> (-1.10%)` | :arrow_down: |
| [...pache/pinot/core/common/BlockMultiValIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmxvY2tNdWx0aVZhbEl0ZXJhdG9yLmphdmE=) | `14.28% <ø> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `63.63% <ø> (ø)` | |
| [...aliterators/DictionaryBasedMultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...literators/DictionaryBasedSingleValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkU2luZ2xlVmFsdWVJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/operator/docvaliterators/MultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `56.25% <0.00%> (-25.57%)` | :arrow_down: |
| [...ava/org/apache/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0ZpbHRlclBsYW5Ob2RlLmphdmE=) | `92.00% <ø> (ø)` | |
| [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [235 more](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=footer). Last update [e682d49...778eb33](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org