You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/25 07:50:48 UTC

[GitHub] [spark] zero323 commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

zero323 commented on pull request #30143:
URL: https://github.com/apache/spark/pull/30143#issuecomment-716107740


   > > Add proper NumPy-style docstrings to expanded functions.
   > 
   > Oh, let's don't do this in this PR.
   
   OK. Shall we extend existing docstrings here at all?
   
   And what about the remaining points? Right now functions are in groups, some are not, some ordered by name, some not. Since we introduce quite a few `defs` here, I thought it might be a good idea to sort this stuff.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org