You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/05/01 15:55:05 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23890: feat: run ci unit+integration tests for py310
sebastianliebscher opened a new pull request, #23890:
URL: https://github.com/apache/superset/pull/23890
### SUMMARY
Running CI integration and unit tests for Python 3.10 is a first step to fully upgrade official release to Python 3.10.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23890: feat!: bump to Python3.9
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1548645027
I marked this as a breaking change. All good for now since we can get it into the 3.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #23890: feat: bump to Python3.9
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23890:
URL: https://github.com/apache/superset/pull/23890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23890: feat: bump to Python3.9
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23890:
URL: https://github.com/apache/superset/pull/23890#discussion_r1189726479
##########
.asf.yaml:
##########
@@ -66,12 +66,12 @@ github:
- cypress-matrix (3, chrome)
- docker-build
- frontend-build
- - pre-commit (3.8)
- - python-lint (3.8)
- - test-mysql (3.8)
- - test-postgres (3.8)
+ - pre-commit (3.9)
+ - python-lint (3.9)
+ - test-mysql (3.9)
- test-postgres (3.9)
- - test-sqlite (3.8)
+ - test-postgres (3.9)
Review Comment:
Shouldn't this be
```suggestion
- test-postgres (3.10)
```
##########
scripts/benchmark_migration.py:
##########
@@ -120,7 +120,7 @@ def find_models(module: ModuleType) -> List[Type[Model]]:
# sort topologically so we can create entities in order and
# maintain relationships (eg, create a database before creating
# a slice)
- sorter = TopologicalSorter()
+ sorter = TopologicalSorter() # type: TopologicalSorter[Any]
Review Comment:
Wouldn't this be the preferred way of specifying the type?
```python
sorter: TopologicalSorter[Any] = TopologicalSorter()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23890: feat: bump to Python3.9
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1540824045
Hi @rusackas! Can you help us with the required CI tests for old Py3.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #23890: feat: bump to Python3.9
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #23890:
URL: https://github.com/apache/superset/pull/23890#discussion_r1189913799
##########
Dockerfile:
##########
@@ -18,7 +18,7 @@
######################################################################
# Node stage to deal with static asset construction
######################################################################
-ARG PY_VER=3.8.16-slim
+ARG PY_VER=3.9.16-slim
Review Comment:
checked that 3.9.16 is the latest 3.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23890: feat: run ci unit+integration tests for py310
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1529904261
## [Codecov](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23890](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (489398c) into [master](https://codecov.io/gh/apache/superset/commit/fd3030fc14dab1c89d198f74c8745b4c22282c9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd3030f) will **decrease** coverage by `11.39%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 489398c differs from pull request most recent head cc3103f. Consider uploading reports for the commit cc3103f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23890 +/- ##
===========================================
- Coverage 68.11% 56.73% -11.39%
===========================================
Files 1938 1938
Lines 74973 74996 +23
Branches 8141 8141
===========================================
- Hits 51068 42549 -8519
- Misses 21826 30368 +8542
Partials 2079 2079
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.93% <ø> (ø)` | |
| python | `59.14% <ø> (-23.54%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.84% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-ui-chart-controls/src/utils/getColorFormatters.ts](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3V0aWxzL2dldENvbG9yRm9ybWF0dGVycy50cw==) | `100.00% <ø> (ø)` | |
| [...harts/src/BigNumber/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `100.00% <ø> (ø)` | |
| [...rts/src/BigNumber/BigNumberTotal/transformProps.ts](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclRvdGFsL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/23890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `51.35% <ø> (ø)` | |
... and [308 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23890/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23890: feat(ci): run unit+integration tests for py310
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1530924874
@sebastianliebscher is adding quotes around the python version the "correct" way? It would be nice to add a note about that in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #23890: feat!: bump to Python3.9
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #23890:
URL: https://github.com/apache/superset/pull/23890#discussion_r1194399813
##########
UPDATING.md:
##########
@@ -46,6 +46,7 @@ assists people when migrating to a new version.
- [21163](https://github.com/apache/superset/pull/21163): The time grain will be decoupled from the time filter column and the time grain control will move below the X-Axis control when `GENERIC_CHART_AXES` feature flags set to `True`. The time grain will be applied on the time column in the column-like controls(x axis, dimensions) instead of the time column in the time section.
- [21284](https://github.com/apache/superset/pull/21284): The non-functional `MAX_TABLE_NAMES` config key has been removed.
- [21794](https://github.com/apache/superset/pull/21794): Deprecates the undocumented `PRESTO_SPLIT_VIEWS_FROM_TABLES` feature flag. Now for Presto, like other engines, only physical tables are treated as tables.
+- [23890](https://github.com/apache/superset/pull/23890): Removes Python 3.8 support.
Review Comment:
I need to create a PR to update this file for 2.1, so I'll move this into Breaking Changes then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on pull request #23890: feat(ci): run unit+integration tests for py310
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1530939884
> @sebastianliebscher is adding quotes around the python version the "correct" way? It would be nice to add a note about that in the description.
@villebro Without the quotes, e.g. `3.10` is interpreted as `3.1`. But you are right, I missed that in the desciption. I updated the desciption accordingly :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on pull request #23890: feat: bump to Python3.9
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1542258343
Also many thanks to @EugeneTorap, great team effort :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23890: feat(ci): run unit+integration tests for py310
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23890:
URL: https://github.com/apache/superset/pull/23890#issuecomment-1530979960
> @villebro Without the quotes, e.g. `3.10` is interpreted as `3.1`. But you are right, I missed that in the desciption. I updated the desciption accordingly 👍
Thanks @sebastianliebscher - makes sense 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #23890: feat: bump to Python3.9
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #23890:
URL: https://github.com/apache/superset/pull/23890#discussion_r1189739371
##########
.asf.yaml:
##########
@@ -66,12 +66,12 @@ github:
- cypress-matrix (3, chrome)
- docker-build
- frontend-build
- - pre-commit (3.8)
- - python-lint (3.8)
- - test-mysql (3.8)
- - test-postgres (3.8)
+ - pre-commit (3.9)
+ - python-lint (3.9)
+ - test-mysql (3.9)
- test-postgres (3.9)
- - test-sqlite (3.8)
+ - test-postgres (3.9)
Review Comment:
@villebro I have done it in #24002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org