You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org> on 2007/10/09 12:32:51 UTC

[jira] Created: (QPID-625) CommitRollbackTest may fail even because test incorrectly specified

CommitRollbackTest may fail even because test incorrectly specified
-------------------------------------------------------------------

                 Key: QPID-625
                 URL: https://issues.apache.org/jira/browse/QPID-625
             Project: Qpid
          Issue Type: Bug
    Affects Versions: M2
            Reporter: Rob Godfrey
            Assignee: Rob Godfrey
             Fix For: M2, M2.1


CommitRollbackTest.testSend2ThenCloseAfter1andTryAgain() occaisionally fails because there is an assertion that the second message to arrive after rollback must be marked as redelivered.  This assertion is based on a false premise as the following scenario is valid

receive ("1", redelivered = false)
rollback
receive("1", redelivered = true)
receive("2", redelivered = false)

Instead the test should assert that if the message content is "1" then redelivered must equal true; and that the content of the two messages received after the rollback must be different (i.e. one must be "1" and one must be "2").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-625) CommitRollbackTest may fail even because test incorrectly specified

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Godfrey resolved QPID-625.
------------------------------

    Resolution: Fixed

Completed: At revision: 583105  


> CommitRollbackTest may fail even because test incorrectly specified
> -------------------------------------------------------------------
>
>                 Key: QPID-625
>                 URL: https://issues.apache.org/jira/browse/QPID-625
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M2
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: M2, M2.1
>
>
> CommitRollbackTest.testSend2ThenCloseAfter1andTryAgain() occaisionally fails because there is an assertion that the second message to arrive after rollback must be marked as redelivered.  This assertion is based on a false premise as the following scenario is valid
> receive ("1", redelivered = false)
> rollback
> receive("1", redelivered = true)
> receive("2", redelivered = false)
> Instead the test should assert that if the message content is "1" then redelivered must equal true; and that the content of the two messages received after the rollback must be different (i.e. one must be "1" and one must be "2").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.