You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CzyerChen (via GitHub)" <gi...@apache.org> on 2023/12/18 08:03:44 UTC
[PR] Support for tracing Spring-Webflux request in Webflux 6.x plugin [skywalking-java]
CzyerChen opened a new pull request, #660:
URL: https://github.com/apache/skywalking-java/pull/660
### Fix #11654 and add support for spring-webflux-6.x
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
### Add an agent plugin to support Spring-Webflux-6.x
- [x] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11654.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support for tracing Spring-Webflux request in Webflux 6.x plugin [skywalking-java]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen closed pull request #660: Support for tracing Spring-Webflux request in Webflux 6.x plugin
URL: https://github.com/apache/skywalking-java/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support for tracing Spring-Webflux request in Webflux 6.x plugin [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #660:
URL: https://github.com/apache/skywalking-java/pull/660#issuecomment-1859755845
What happened here?
A tip, if you are adding new toolkit, please
1. Make sure it is necessary, such as WebFlux 5.x and 6.x expose different APIs for toolkit compilings.
2. Docs should be updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support for tracing Spring-Webflux request in Webflux 6.x plugin [skywalking-java]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #660:
URL: https://github.com/apache/skywalking-java/pull/660#issuecomment-1859759728
> What happened here?
>
> A tip, if you are adding new toolkit, please
>
> 1. Make sure it is necessary, such as WebFlux 5.x and 6.x expose different APIs for toolkit compilings.
> 2. Docs should be updated accordingly.
I can think about this again, and redo the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org