You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/22 10:21:44 UTC
[GitHub] [spark] goutam-git opened a new pull request, #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
goutam-git opened a new pull request, #37613:
URL: https://github.com/apache/spark/pull/37613
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Migrate the following errors in QueryExecutionErrors:
- failedToCastValueToDataTypeForPartitionColumnError
- invalidInputSyntaxForNumericError
- cannotCastToDateTimeError
- invalidInputSyntaxForBooleanError
- nullLiteralsCannotBeCastedError
onto use error classes. Throw an implementation of SparkThrowable. Also write a test per every error in QueryExecutionErrorsSuite.
Please Note invalidInputSyntaxForNumericError and cannotCastToDateTimeError are not present in any more and invalidInputSyntaxForBooleanError is already using error classes.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To follow the error class framework and improve test coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
mvn -Dtest=none -DwildcardSuites=org.apache.spark.sql.errors.QueryExecutionErrorsSuite test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37613:
URL: https://github.com/apache/spark/pull/37613#issuecomment-1338459852
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
URL: https://github.com/apache/spark/pull/37613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] goutam-git commented on a diff in pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
goutam-git commented on code in PR #37613:
URL: https://github.com/apache/spark/pull/37613#discussion_r952153117
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -653,26 +653,6 @@ class QueryExecutionErrorsSuite
"alternative" -> "",
"config" -> SQLConf.ANSI_ENABLED.key))
}
-
- test("CAST_OVERFLOW: from long to ANSI intervals") {
- Seq(
- LongType -> "9223372036854775807L",
- DecimalType(19, 0) -> "9223372036854775807BD").foreach { case (sourceType, sourceValue) =>
- Seq("INTERVAL YEAR TO MONTH", "INTERVAL HOUR TO MINUTE").foreach { it =>
- checkError(
- exception = intercept[SparkArithmeticException] {
- sql(s"select CAST($sourceValue AS $it)").collect()
- },
- errorClass = "CAST_OVERFLOW",
Review Comment:
It must have got removed during merge. Sorry for the unintentional mistake. Added the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] goutam-git commented on pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
goutam-git commented on PR #37613:
URL: https://github.com/apache/spark/pull/37613#issuecomment-1229204689
Not able to build because of
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:2231:82: no arguments allowed for nullary method elementAtByIndexZeroError: ()org.apache.spark.SparkRuntimeException
[error] throw QueryExecutionErrors.elementAtByIndexZeroError(getContextOrNull())
@MaxGekk
can you please help resolve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37613:
URL: https://github.com/apache/spark/pull/37613#issuecomment-1223035649
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37613: [SPARK-37944][SQL] Use error classes in the execution errors of casting
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37613:
URL: https://github.com/apache/spark/pull/37613#discussion_r951642329
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -653,26 +653,6 @@ class QueryExecutionErrorsSuite
"alternative" -> "",
"config" -> SQLConf.ANSI_ENABLED.key))
}
-
- test("CAST_OVERFLOW: from long to ANSI intervals") {
- Seq(
- LongType -> "9223372036854775807L",
- DecimalType(19, 0) -> "9223372036854775807BD").foreach { case (sourceType, sourceValue) =>
- Seq("INTERVAL YEAR TO MONTH", "INTERVAL HOUR TO MINUTE").foreach { it =>
- checkError(
- exception = intercept[SparkArithmeticException] {
- sql(s"select CAST($sourceValue AS $it)").collect()
- },
- errorClass = "CAST_OVERFLOW",
Review Comment:
Why do you remove this check for `CAST_OVERFLOW`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org