You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/21 12:48:56 UTC
[GitHub] [pulsar] xche opened a new pull request #8664: [Functions] Create per instance pulsar clients. #8575
xche opened a new pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664
Move create PulsarClient from ThreadRuntimeFactory to JavaInstanceRunnable
Motivation
The reason for this problem is that there is only one PulsarClient in a functionWorker instance, and the number of externalExecutorProvider thread pools in PulsarClient is 1, so all consumers share the same listener executor. Therefore, when one or more tasks stoped, the listener executor will be blocked, and finally other tasks will stop consuming data.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
xche commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-731575428
@jerrypeng This pr is for "The correct solution would be to change the number listener threads for the pulsar client used in the TheadRuntime or create per instance pulsar clients."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
xche commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-731574760
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-733405755
@jiazhai sorry for the late response.
This PR is LGTM, and solved #8575 by adding per instance pulsar client for each thread function. But we should dig a little bit deeper to find out why the queue is blocked under shared pulsar client in thread runtime mode. Ideally, when one or more functions stop, the client should keep consuming data for the rest functions, and one or more functions' change should not affect other functions' condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
xche commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-809874660
Each task instance has one client, which leads to CPU consumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-731692214
@xche Thanks a lot for the help. Is it possible to add a test to cover the original error: `when one or more tasks stoped, the listener executor will be blocked, and finally other tasks will stop consuming data`. This will protect this part of the fix, and also help a lot to verify this fix.
@freeznet Would you please also take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664#issuecomment-731690502
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche closed pull request #8664: [Functions] Create per instance pulsar clients. #8575
Posted by GitBox <gi...@apache.org>.
xche closed pull request #8664:
URL: https://github.com/apache/pulsar/pull/8664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org