You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Przemo Pakulski (JIRA)" <ji...@apache.org> on 2007/12/19 18:32:43 UTC
[jira] Created: (JCR-1277) ConnectionRecoveryManager is created
twice in DBDataStore init method
ConnectionRecoveryManager is created twice in DBDataStore init method
---------------------------------------------------------------------
Key: JCR-1277
URL: https://issues.apache.org/jira/browse/JCR-1277
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-core
Reporter: Przemo Pakulski
Priority: Trivial
Fix For: 1.4
It seems that after introducing pool, old initizialization of ConnectionRecoveryManager has not been removed.
Index: DbDataStore.java
===================================================================
--- DbDataStore.java (revision 605626)
+++ DbDataStore.java (working copy)
@@ -479,8 +479,6 @@
initDatabaseType();
connectionPool = new Pool(this, maxConnections);
ConnectionRecoveryManager conn = getConnection();
- conn = new ConnectionRecoveryManager(false, driver, url, user, password);
- conn.setAutoReconnect(true);
DatabaseMetaData meta = conn.getConnection().getMetaData();
log.info("Using JDBC driver " + meta.getDriverName() + " " + meta.getDriverVersion());
meta.getDriverVersion();
Duplicated initialization should be removed , but i've never run this code yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1277) ConnectionRecoveryManager is created
twice in DBDataStore init method
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553422 ]
Thomas Mueller commented on JCR-1277:
-------------------------------------
Hi,
Your are right of course! I will test the change and then commit it if nobody objects.
Regards,
Thomas
> ConnectionRecoveryManager is created twice in DBDataStore init method
> ---------------------------------------------------------------------
>
> Key: JCR-1277
> URL: https://issues.apache.org/jira/browse/JCR-1277
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Przemo Pakulski
> Priority: Trivial
> Fix For: 1.4
>
>
> It seems that after introducing pool, old initizialization of ConnectionRecoveryManager has not been removed.
> Index: DbDataStore.java
> ===================================================================
> --- DbDataStore.java (revision 605626)
> +++ DbDataStore.java (working copy)
> @@ -479,8 +479,6 @@
> initDatabaseType();
> connectionPool = new Pool(this, maxConnections);
> ConnectionRecoveryManager conn = getConnection();
> - conn = new ConnectionRecoveryManager(false, driver, url, user, password);
> - conn.setAutoReconnect(true);
> DatabaseMetaData meta = conn.getConnection().getMetaData();
> log.info("Using JDBC driver " + meta.getDriverName() + " " + meta.getDriverVersion());
> meta.getDriverVersion();
> Duplicated initialization should be removed , but i've never run this code yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1277) ConnectionRecoveryManager is created
twice in DBDataStore init method
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller resolved JCR-1277.
---------------------------------
Resolution: Fixed
Assignee: Thomas Mueller
Fixed in revision 606170
> ConnectionRecoveryManager is created twice in DBDataStore init method
> ---------------------------------------------------------------------
>
> Key: JCR-1277
> URL: https://issues.apache.org/jira/browse/JCR-1277
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: Przemo Pakulski
> Assignee: Thomas Mueller
> Priority: Trivial
> Fix For: 1.4
>
>
> It seems that after introducing pool, old initizialization of ConnectionRecoveryManager has not been removed.
> Index: DbDataStore.java
> ===================================================================
> --- DbDataStore.java (revision 605626)
> +++ DbDataStore.java (working copy)
> @@ -479,8 +479,6 @@
> initDatabaseType();
> connectionPool = new Pool(this, maxConnections);
> ConnectionRecoveryManager conn = getConnection();
> - conn = new ConnectionRecoveryManager(false, driver, url, user, password);
> - conn.setAutoReconnect(true);
> DatabaseMetaData meta = conn.getConnection().getMetaData();
> log.info("Using JDBC driver " + meta.getDriverName() + " " + meta.getDriverVersion());
> meta.getDriverVersion();
> Duplicated initialization should be removed , but i've never run this code yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.