You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Clafou <gi...@git.apache.org> on 2014/09/18 12:21:50 UTC
[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...
GitHub user Clafou opened a pull request:
https://github.com/apache/cordova-ios/pull/105
Fixed the CDV_IsIPhone5() macro for iOS8 landscape
iOS8 introduces a change to screen orientation, making [UIScreen bounds] orientation-dependent. As a result, testing if the screen resolution matches the iPhone5, as this macro does, now needs to account for landscape (568x320) in addition to portrait (320x568).
Details at http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bounds-size-becoming-orientation-dependent-in-ios8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Clafou/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 6b8ca71e9b04ce39c20f9f2aeb3a6c4e5785aa6d
Author: Clafou <se...@wiggleworm.local>
Date: 2014-09-18T10:18:04Z
Fixed the CDV_IsIPhone5() macro for iOS8 landscape
iOS8 introduces a change to screen orientation, making [UIScreen
bounds] orientation-dependent. Testing for the iPhone5 screen
resolution now needs to account for landscape (568x320) in addition to
portrait (320x568).
Details at
http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bound
s-size-becoming-orientation-dependent-in-ios8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/105#issuecomment-56101072
Ouch, yeah this resulted in a bug for the statusbar plugin as well for landscape (fixed) :/
Filed https://issues.apache.org/jira/browse/CB-7596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...
Posted by Clafou <gi...@git.apache.org>.
Github user Clafou commented on the pull request:
https://github.com/apache/cordova-ios/pull/105#issuecomment-56118693
Thanks, glad to help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/105#issuecomment-56112665
Patch integrated: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b06ca8d
You can close this PR now, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...
Posted by Clafou <gi...@git.apache.org>.
Github user Clafou closed the pull request at:
https://github.com/apache/cordova-ios/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---