You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Carsten Klein (JIRA)" <ji...@apache.org> on 2012/05/05 18:49:52 UTC
[jira] [Created] (TAP5-1925) Rename t:remove to t:annotation
Carsten Klein created TAP5-1925:
-----------------------------------
Summary: Rename t:remove to t:annotation
Key: TAP5-1925
URL: https://issues.apache.org/jira/browse/TAP5-1925
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.3.3
Reporter: Carsten Klein
Priority: Minor
I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269132#comment-13269132 ]
Robert Zeigler commented on TAP5-1925:
--------------------------------------
Your proposed renaming assumes that the only use for <t:remove> is to annotate some piece of the template. Although that is certainly one potential use of <t:remove>, it's not the only use. I'm -1 on a rename to "annotation". It's confusing, overloaded, and less general than "remove". I've never found "remove" unintuitive:
<t:remove>
A bunch of stuff to remove from the template
</t:remove>
Seems pretty obvious.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269051#comment-13269051 ]
Bob Harner commented on TAP5-1925:
----------------------------------
The term "annotation" already has a different meaning in the Java world, so although I agree with you that "remove" is a little unintuitive, I think "annotation" might be worse.
However, if you want to make an "annotation" component of your own, feel free. It would be truly trivial to do:
package com.mycompany.myapp.components;
public class Annotation
{
boolean setupRender()
{
return false;
}
}
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269236#comment-13269236 ]
Bob Harner commented on TAP5-1925:
----------------------------------
In JSF the equivalent tag is <ui:remove>
In Wicket it's <wicket:remove>
In JSP, Struts & Grails it's <%-- ..... --%>
I'm liking <t:remove> more and more.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269051#comment-13269051 ]
Bob Harner commented on TAP5-1925:
----------------------------------
The term "annotation" already has a different meaning in the Java world, so although I agree with you that "remove" is a little unintuitive, I think "annotation" might be worse.
However, if you want to make an "annotation" component of your own, feel free. It would be truly trivial to do:
package com.mycompany.myapp.components;
public class Annotation
{
boolean setupRender()
{
return false;
}
}
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269132#comment-13269132 ]
Robert Zeigler commented on TAP5-1925:
--------------------------------------
Your proposed renaming assumes that the only use for <t:remove> is to annotate some piece of the template. Although that is certainly one potential use of <t:remove>, it's not the only use. I'm -1 on a rename to "annotation". It's confusing, overloaded, and less general than "remove". I've never found "remove" unintuitive:
<t:remove>
A bunch of stuff to remove from the template
</t:remove>
Seems pretty obvious.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269202#comment-13269202 ]
Thiago H. de Paula Figueiredo commented on TAP5-1925:
-----------------------------------------------------
On Sat, 05 May 2012 23:51:47 -0300, Carsten Klein (JIRA) <ji...@apache.org>
I don't think what you're saying is correct. Since Tapestry 5.2, there's a
single instance of each page loaded in memory and there's no per-thread
copy of template of pages nor components, so you're concern is not valid
AFAIK.
--
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
On Sat, 05 May 2012 23:51:47 -0300, Carsten Klein (JIRA) <ji...@apache.org>
wrote:
> The least I wanted to have was an otherwise useless component consuming
> valuable memory, and you know that comments can get rather lengthy. Your
> approach would keep all of this in memory for all templates loaded on a
> per thread basis...
I don't think what you're saying is correct. Since Tapestry 5.2, there's a
single instance of each page loaded in memory and there's no per-thread
copy of template of pages nor components, so you're concern is not valid
AFAIK.
--
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Carsten Klein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269107#comment-13269107 ]
Carsten Klein commented on TAP5-1925:
-------------------------------------
Not an option :D -- cf. SaxTemplateParser which removes the content during template parse.
The least I wanted to have was an otherwise useless component consuming valuable memory,
and you know that comments can get rather lengthy. Your approach would keep all of this
in memory for all templates loaded on a per thread basis...
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269236#comment-13269236 ]
Bob Harner commented on TAP5-1925:
----------------------------------
In JSF the equivalent tag is <ui:remove>
In Wicket it's <wicket:remove>
In JSP, Struts & Grails it's <%-- ..... --%>
I'm liking <t:remove> more and more.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Carsten Klein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269107#comment-13269107 ]
Carsten Klein commented on TAP5-1925:
-------------------------------------
Not an option :D -- cf. SaxTemplateParser which removes the content during template parse.
The least I wanted to have was an otherwise useless component consuming valuable memory,
and you know that comments can get rather lengthy. Your approach would keep all of this
in memory for all templates loaded on a per thread basis...
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner resolved TAP5-1925.
------------------------------
Resolution: Won't Fix
The same functionality is available in most if not all template-based web frameworks. Carsten, can you cite any that use "annotation" for this purpose? I like that Tapestry, JSF and Wicket all use the same word.
I'm marking this issue as "Won't Fix", for the reasons cited. Reopen if you really feel strongly about it.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner resolved TAP5-1925.
------------------------------
Resolution: Won't Fix
The same functionality is available in most if not all template-based web frameworks. Carsten, can you cite any that use "annotation" for this purpose? I like that Tapestry, JSF and Wicket all use the same word.
I'm marking this issue as "Won't Fix", for the reasons cited. Reopen if you really feel strongly about it.
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1925) Rename t:remove to t:annotation
Posted by "Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269202#comment-13269202 ]
Thiago H. de Paula Figueiredo commented on TAP5-1925:
-----------------------------------------------------
On Sat, 05 May 2012 23:51:47 -0300, Carsten Klein (JIRA) <ji...@apache.org>
I don't think what you're saying is correct. Since Tapestry 5.2, there's a
single instance of each page loaded in memory and there's no per-thread
copy of template of pages nor components, so you're concern is not valid
AFAIK.
--
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br
> Rename t:remove to t:annotation
> -------------------------------
>
> Key: TAP5-1925
> URL: https://issues.apache.org/jira/browse/TAP5-1925
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Carsten Klein
> Priority: Minor
>
> I am quite unhappy with the naming of the component used for server side comments/annotations attached to a template.
> t:remove seems a bit awkward, albeit it does reflect on what the template engine actually does.
> I would recommend deprecating t:remove and introduce a t:annotation component in its favor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira