You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zhou Xu (Code Review)" <ge...@cloudera.org> on 2019/12/12 09:25:09 UTC
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Zhou Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14896
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) -> to_timestamp('timestr', 'fmt')
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
2 files changed, 79 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/1
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5359/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 3
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Jan 2020 09:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
This change will help with queries generated by some BI tools.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) -> to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/4
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5389/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 5
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 11:32:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java:
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@40
PS1, Line 40: SimplifyCastStringToTimestamp
> Please add some tests to ExprRewriteRulesTest.java
Done
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 10:44:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14896/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14896/3//COMMIT_MSG@8
PS3, Line 8:
nit: Please add a comment that this change will help with queries generated by some BI tools.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 3
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jan 2020 14:59:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
This change will help with queries generated by some BI tools.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) ->
cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) ->
to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/5
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 5
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5387/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 08:37:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) -> to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 97 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/2
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 6
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 16:17:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-9035: Simplify casting string to timestamp.
Please insert a new empty line between L7 and L8.
The subject line should always be followed with an empty line.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 10:30:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
This change will help with queries generated by some BI tools.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) ->
cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) ->
to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/6
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 6
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 2:
(4 comments)
Hey,
Sorry for the delay. Most of us were off at the end of the year. I have some minor comments. Once you take care of them I'm fine to +2.
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java:
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@56
PS1, Line 56: simplified
> nit: simplified_expr would be a more verbose name
Any comment on this?
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@66
PS1, Line 66: Lists.newArrayList(fce.getChildren()));
The preferred indentation for broken lines is 4 spaces.
http://gerrit.cloudera.org:8080/#/c/14896/2/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:
http://gerrit.cloudera.org:8080/#/c/14896/2/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@786
PS2, Line 786: null);
nit: this fits into the line above
http://gerrit.cloudera.org:8080/#/c/14896/2/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@788
PS2, Line 788: null);
nit: this fits into the line above
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 12:27:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14896/4//COMMIT_MSG@8
PS4, Line 8: This change will help with queries generated by some BI tools.
: Case 1:
: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
: cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as timestamp)
: Case 2:
: Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
: cast(unix_timestamp('timestr', 'fmt') as timestamp) -> to_timestamp('timestr', 'fmt')
Also, please wrap long lines at 70 characters.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 10:38:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5300/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 11:12:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5266/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 09:54:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5390/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 6
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 11:36:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 6
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 11:45:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) -> to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14896/3
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 3
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 3
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jan 2020 15:00:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 1:
(2 comments)
Thanks for sending this patch! This seems good in overall, however I also miss the test coverage.
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java:
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@56
PS1, Line 56: simplified
nit: simplified_expr would be a more verbose name
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@58
PS1, Line 58: isStringType
As far as I know this includes char arrays as well. Those introduce one more step in the conversion for char[n] -> string. Have you tried testing with this type as well?
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 15:38:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
IMPALA-9035: Simplify casting string to timestamp.
This change will help with queries generated by some BI tools.
Case 1:
Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr') as timestamp) ->
cast('timestr' as timestamp)
Case 2:
Simplify 'string[fmt] -> bigint -> timestamp' TO 'string -> timestamp':
cast(unix_timestamp('timestr', 'fmt') as timestamp) ->
to_timestamp('timestr', 'fmt')
Tests:
Add front-end tests in ExprRewriteRulesTest.
Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Reviewed-on: http://gerrit.cloudera.org:8080/14896
Reviewed-by: Attila Jeges <at...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
3 files changed, 95 insertions(+), 0 deletions(-)
Approvals:
Attila Jeges: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 7
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 1:
(2 comments)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@76
PS1, Line 76: import org.apache.impala.rewrite.SimplifyCastStringToTimestamp;
nit: please move this line after L73 to keep the imports alphabetically ordered.
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java:
http://gerrit.cloudera.org:8080/#/c/14896/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java@40
PS1, Line 40: SimplifyCastStringToTimestamp
Please add some tests to ExprRewriteRulesTest.java
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 14:38:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5392/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 6
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 11:47:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 3: Code-Review+1
Thanks for making these changes! I'm fine here. Let me give a +1 and let's wait for Attila Jeges if he has anything to add.
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 3
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Jan 2020 09:23:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.
Posted by "Zhou Xu (Code Review)" <ge...@cloudera.org>.
Zhou Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp.
......................................................................
Patch Set 2:
Any progress?
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Dec 2019 07:12:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix timestamp('timestr') as timestamp) -> cast('timestr' as
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 )
Change subject: IMPALA-9035: Simplify casting string to timestamp. This change will help with queries generated by some BI tools. Case 1: Simplify 'string -> bigint -> timestamp' TO 'string -> timestamp': cast(unix_timestamp('timestr') as timestamp) -> cast('timestr' as
......................................................................
Patch Set 4: Code-Review+2
Thanks! Let's carry Attila's +2
--
To view, visit http://gerrit.cloudera.org:8080/14896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed72d6e7886eaf50d2be60cf45170ffaef5e72d
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 4
Gerrit-Owner: Zhou Xu <pe...@gmail.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zhou Xu <pe...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2020 09:24:06 +0000
Gerrit-HasComments: No