You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/01 21:19:33 UTC

Re: Review Request 28444: Expanded labels comment in mesos.proto.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28444/#review63428
-----------------------------------------------------------

Ship it!


Much appreciated Nik!


include/mesos/mesos.proto
<https://reviews.apache.org/r/28444/#comment105681>

    Thanks Nik!
    
    Mind adding a newline before the start of the comment? Not sure why the lack of newlines was missed for ContainerInfo/HealthCheck, but the rest of this file uses whitespace. :)


- Ben Mahler


On Nov. 25, 2014, 6:27 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28444/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 6:27 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba 
> 
> Diff: https://reviews.apache.org/r/28444/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>