You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2025/05/07 09:44:22 UTC

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22863


Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................

IMPALA-14040: Remove Kudu masters property from FeCatalog

This change removes getDefaultKuduMasterHosts from FeCatalog and makes
the Kudu masters lookup bound directly to the backend config.

Tests are adjusted for the new property lookup.

Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/FeCatalogManager.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
13 files changed, 37 insertions(+), 40 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/22863/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 11:41:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19137/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 12:03:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................

IMPALA-14040: Remove Kudu masters property from FeCatalog

This change removes getDefaultKuduMasterHosts from FeCatalog and makes
the Kudu masters lookup bound directly to the backend config.

Tests are adjusted for the new property lookup.

Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/FeCatalogManager.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
13 files changed, 37 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/22863/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has removed a vote on this change.

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11863/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 19:26:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@38
PS2, Line 38: Before
We could use "@BeforeClass" instead, with a static method.



-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 11:06:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 19:26:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 4: Verified+1 Code-Review+2

The failed test is a known flaky test: IMPALA-14046. I think we can merge this.


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 08:38:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:49:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19136/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 10:11:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11863/


-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 02:04:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/22863/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@38
PS2, Line 38: Before
> We could use "@BeforeClass" instead, with a static method.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 11:37:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14040: Remove Kudu masters property from FeCatalog

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22863 )

Change subject: IMPALA-14040: Remove Kudu masters property from FeCatalog
......................................................................

IMPALA-14040: Remove Kudu masters property from FeCatalog

This change removes getDefaultKuduMasterHosts from FeCatalog and makes
the Kudu masters lookup bound directly to the backend config.

Tests are adjusted for the new property lookup.

Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Reviewed-on: http://gerrit.cloudera.org:8080/22863
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Daniel Becker <da...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/FeCatalogManager.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
13 files changed, 37 insertions(+), 40 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Daniel Becker: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcf31a724bb7bd00268accf21c0b997d92e9b23a
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>