You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/04/13 10:10:30 UTC

Review Request: Expose the xid and cid when show status of job in sqoop2 client

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10444/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

In this patch, 
>show connection --xid arg 
prints connector id with other properties

>show job --xid arg
prints connection id and connector id with other properties

Included a fix in create connection function where it was printing resource key in shell.


This addresses bug SQOOP-876.
    https://issues.apache.org/jira/browse/SQOOP-876


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java cc956d0 
  client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 04238ee 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4fe20c1 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 5505d51 
  client/src/main/resources/client-resource.properties feb09e0 

Diff: https://reviews.apache.org/r/10444/diff/


Testing
-------

Done


Thanks,

vasanthkumar


Re: Review Request: Expose the xid and cid when show status of job in sqoop2 client

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10444/#review19123
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On April 13, 2013, 8:10 a.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10444/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 8:10 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> In this patch, 
> >show connection --xid arg 
> prints connector id with other properties
> 
> >show job --xid arg
> prints connection id and connector id with other properties
> 
> Included a fix in create connection function where it was printing resource key in shell.
> 
> 
> This addresses bug SQOOP-876.
>     https://issues.apache.org/jira/browse/SQOOP-876
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java cc956d0 
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 04238ee 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4fe20c1 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 5505d51 
>   client/src/main/resources/client-resource.properties feb09e0 
> 
> Diff: https://reviews.apache.org/r/10444/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>