You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/06/22 19:48:55 UTC
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10799
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
IMPALA-6802 (part 5): Clean up authorization tests
The fifth part of this patch is to rewrite the following authorization
tests:
- compute/drop stats
- create database/table/view
- drop database/table/view
Cherry-picks: not for 2.x
Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
---
R fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
1 file changed, 538 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10799/2
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 23:23:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
IMPALA-6802 (part 5): Clean up authorization tests
The fifth part of this patch is to rewrite the following authorization
tests:
- compute/drop stats
- create database/table/view
- drop database/table/view
Cherry-picks: not for 2.x
Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
---
R fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
1 file changed, 538 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10799/3
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
IMPALA-6802 (part 5): Clean up authorization tests
The fifth part of this patch is to rewrite the following authorization
tests:
- compute/drop stats
- create database/table/view
- drop database/table/view
Cherry-picks: not for 2.x
Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Reviewed-on: http://gerrit.cloudera.org:8080/10799
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
R fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
1 file changed, 538 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 17:23:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Carry +1
http://gerrit.cloudera.org:8080/#/c/10799/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/10799/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1199
PS2, Line 1199: j
> nit: 5 spaces
Done
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 16:08:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2740/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 23:23:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Just 1 nit.
http://gerrit.cloudera.org:8080/#/c/10799/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/10799/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1199
PS2, Line 1199:
nit: 5 spaces
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 16:03:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 02:38:22 +0000
Gerrit-HasComments: No