Re: [Axis2 Build Failing] Re: svn commit: r396597 - /webservices/commons/trunk/modules/axiom/src/org/apache/axiom/soap/impl/llom/soap11/SOAP11Factory.java

[Glen Daniels <gl...@thoughtcraft.com>]

Hey all:

First off, I in fact had no idea my change broke the security stuff!  My 
Axis2 build did work, but I'm assuming that's because I had an older 
policy jar in my repo somehow.  Eran was totally within his rights to 
revert the change, and I agree completely that Axiom changes should 
ideally run through an Axis test cycle.  However, this is really more of 
a problem right now than it will be after we switch to using real 
releases instead of SNAPSHOTs - and also more of an issue because 1.0 is 
hoping to get out the door soon.  My apologies for the break.

Sanjiva Weerawarana wrote:
> Finally the request was made to Glen, a core developer of both Axiom and
> Axis2. I'm sure Glen didn't know that his change broke Axis2- otherwise
> he'd either not have made the change or fixed Axis2 himself.

+1.  I hope to look into what the problem is later today.

> The change is not critical for Axis2. However, it is a "good thing" kind
> of change in general which we should do .. but its not fundamentally
> critical that we get that into 1.0. If it can be made to work on time of
> course we can get it in yet.

Synapse was barfing for me without this change because the XPath code 
expected the SOAPEnvelope to have a parent, and I figured the change 
wouldn't be an issue because anyone else using SOAPEnvelope would just 
set the parent themselves (replacing the default I added).  Clearly the 
security code has some problem with this.

--Glen

Re: [Axis2 Build Failing] Re: svn commit: r396597 - /webservices/commons/trunk/modules/axiom/src/org/apache/axiom/soap/impl/llom/soap11/SOAP11Factory.java

[Glen Daniels <gl...@thoughtcraft.com>]

Hi dims:

Davanum Srinivas wrote:
> Was talking to Ruchith, Can u please try add back your change in your
> sandbox and run testConvert1() in
> org.apache.axiom.om.impl.dom.ConvertLLOMToDOOMTest - that should
> fail...Once we get that fixed security tests should pass.

Will do, thanks!

--G

Re: [Axis2 Build Failing] Re: svn commit: r396597 - /webservices/commons/trunk/modules/axiom/src/org/apache/axiom/soap/impl/llom/soap11/SOAP11Factory.java

[Glen Daniels <gl...@thoughtcraft.com>]

Hey folks:

> Was talking to Ruchith, Can u please try add back your change in your
> sandbox and run testConvert1() in
> org.apache.axiom.om.impl.dom.ConvertLLOMToDOOMTest - that should
> fail...Once we get that fixed security tests should pass.

It appears things are working now over on the Synapse side without 
adding this change, so I'm going to leave it out for now....

--Glen

Re: [Axis2 Build Failing] Re: svn commit: r396597 - /webservices/commons/trunk/modules/axiom/src/org/apache/axiom/soap/impl/llom/soap11/SOAP11Factory.java

[Davanum Srinivas <da...@gmail.com>]

Glen,

Was talking to Ruchith, Can u please try add back your change in your
sandbox and run testConvert1() in
org.apache.axiom.om.impl.dom.ConvertLLOMToDOOMTest - that should
fail...Once we get that fixed security tests should pass.

thanks,
dims

On 4/25/06, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Hey all:
>
> First off, I in fact had no idea my change broke the security stuff!  My
> Axis2 build did work, but I'm assuming that's because I had an older
> policy jar in my repo somehow.  Eran was totally within his rights to
> revert the change, and I agree completely that Axiom changes should
> ideally run through an Axis test cycle.  However, this is really more of
> a problem right now than it will be after we switch to using real
> releases instead of SNAPSHOTs - and also more of an issue because 1.0 is
> hoping to get out the door soon.  My apologies for the break.
>
> Sanjiva Weerawarana wrote:
> > Finally the request was made to Glen, a core developer of both Axiom and
> > Axis2. I'm sure Glen didn't know that his change broke Axis2- otherwise
> > he'd either not have made the change or fixed Axis2 himself.
>
> +1.  I hope to look into what the problem is later today.
>
> > The change is not critical for Axis2. However, it is a "good thing" kind
> > of change in general which we should do .. but its not fundamentally
> > critical that we get that into 1.0. If it can be made to work on time of
> > course we can get it in yet.
>
> Synapse was barfing for me without this change because the XPath code
> expected the SOAPEnvelope to have a parent, and I figured the change
> wouldn't be an issue because anyone else using SOAPEnvelope would just
> set the parent themselves (replacing the default I added).  Clearly the
> security code has some problem with this.
>
> --Glen
>


--
Davanum Srinivas : http://wso2.com/blogs/