You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2006/04/26 03:26:18 UTC

svn commit: r397044 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java

Author: dion
Date: Tue Apr 25 18:25:57 2006
New Revision: 397044

URL: http://svn.apache.org/viewcvs?rev=397044&view=rev
Log:
Use StringBuffer rather than looping string concats

Modified:
    jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java

Modified: jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java?rev=397044&r1=397043&r2=397044&view=diff
==============================================================================
--- jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java (original)
+++ jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java Tue Apr 25 18:25:57 2006
@@ -101,20 +101,20 @@
              *  whoops.  Ambiguous.  Make a nice log message and return null...
              */
 
-            String msg = "Introspection Error : Ambiguous method invocation "
-                + name + "( ";
+            StringBuffer msg = new StringBuffer("Introspection Error : Ambiguous method invocation ")
+                .append(name).append("( ");
 
             for (int i = 0; i < params.length; i++)
             {
                 if ( i > 0)
-                    msg += ", ";
+                    msg.append(", ");
                 
-                msg += params[i].getClass().getName();
+                msg.append(params[i].getClass().getName());
             }
             
-            msg = msg + ") for class " + c;
+            msg.append(") for class ").append(c.getName());
             
-            rlog.error( msg );
+            rlog.error( msg.toString() );
         }
 
         return null;



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org