You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "aweisberg (via GitHub)" <gi...@apache.org> on 2023/08/23 20:52:37 UTC
[GitHub] [cassandra-accord] aweisberg opened a new pull request, #64: Compaction purger fix
aweisberg opened a new pull request, #64:
URL: https://github.com/apache/cassandra-accord/pull/64
shouldCleanup can't enforce invariants because some of the time we are checking an invalid slice of command state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] aweisberg commented on a diff in pull request #64: Compaction purger fix
Posted by "aweisberg (via GitHub)" <gi...@apache.org>.
aweisberg commented on code in PR #64:
URL: https://github.com/apache/cassandra-accord/pull/64#discussion_r1304583769
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -895,6 +900,7 @@ public static Cleanup shouldCleanup(TxnId txnId, Status status, Durability durab
return Cleanup.ERASE;
}
+ // TODO (review): If we always send the full route when will this happen?
Review Comment:
Yeah you are right it can be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #64: Compaction purger fix
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #64:
URL: https://github.com/apache/cassandra-accord/pull/64#discussion_r1303597890
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -895,6 +900,7 @@ public static Cleanup shouldCleanup(TxnId txnId, Status status, Durability durab
return Cleanup.ERASE;
}
+ // TODO (review): If we always send the full route when will this happen?
Review Comment:
`Route.isFullRoute` allows `null`... but at this point it "shouldn't" be null? Im in favor of keeping it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] aweisberg closed pull request #64: Compaction purger fix
Posted by "aweisberg (via GitHub)" <gi...@apache.org>.
aweisberg closed pull request #64: Compaction purger fix
URL: https://github.com/apache/cassandra-accord/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #64: Compaction purger fix
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #64:
URL: https://github.com/apache/cassandra-accord/pull/64#discussion_r1303585026
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -895,6 +900,7 @@ public static Cleanup shouldCleanup(TxnId txnId, Status status, Durability durab
return Cleanup.ERASE;
}
+ // TODO (review): If we always send the full route when will this happen?
Review Comment:
in C* side I saw that `route` is `null` before, so this can happen when compaction purger interacts with it; not seen your new C* side though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org