You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/25 08:44:44 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
masayuki2009 opened a new pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839
## Summary
- This commit fixes stack corruption for rv64 configs
## Impact
- None
## Testing
- Tested with qemu-6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835074615
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -47,6 +47,7 @@ CONFIG_DEV_ZERO=y
CONFIG_FS_PROCFS=y
CONFIG_IDLETHREAD_STACKSIZE=2048
CONFIG_INIT_ENTRYPOINT="nsh_main"
Review comment:
It's better to increase stack size for nsh also, like maix-bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835092550
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2021
CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_STACKSIZE=3072
Review comment:
Change to CONFIG_INIT_STACKSIZE=3072 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835104607
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2021
CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_STACKSIZE=3072
Review comment:
CONFIG_ARCH_INTERRUPTSTACK seems restored to 2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835098980
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2021
CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_STACKSIZE=3072
Review comment:
@no1wudi
I've already changed the CONFIG_INIT_STACKSIZE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835092550
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2021
CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_STACKSIZE=3072
Review comment:
Please change to CONFIG_INIT_STACKSIZE=3072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839#discussion_r835107529
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh64/defconfig
##########
@@ -65,6 +66,7 @@ CONFIG_STACK_COLORATION=y
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2021
CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_STACKSIZE=3072
Review comment:
@no1wudi
As long as I tested, 2048 is enough for CONFIG_ARCH_INTERRUPTSTACK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5839: boards: rv-virt: Fix stack corruption for rv64 configs
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5839:
URL: https://github.com/apache/incubator-nuttx/pull/5839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org