You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/11 23:06:32 UTC

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9267: [Charts] Use the Edit Properties modal throughout React views

suddjian commented on a change in pull request #9267: [Charts] Use the Edit Properties modal throughout React views
URL: https://github.com/apache/incubator-superset/pull/9267#discussion_r391319891
 
 

 ##########
 File path: superset-frontend/src/explore/components/DisplayQueryButton.jsx
 ##########
 @@ -65,7 +68,7 @@ const defaultProps = {
   animation: true,
 };
 
-export default class DisplayQueryButton extends React.PureComponent {
+export class DisplayQueryButton extends React.PureComponent {
 
 Review comment:
   This is exporting it for testing purposes. It didn't used to be a connected component and the tests depend on accessing it directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org