[GitHub] markusthoemmes commented on a change in pull request #3526: Add gatling as performance test suite.

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3526: Add gatling as performance test suite.
URL: https://github.com/apache/incubator-openwhisk/pull/3526#discussion_r180395584
 
 

 ##########
 File path: performance/gatling_tests/src/gatling/scala/ApiV1Simulation.scala
 ##########
 @@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import extension.whisk.Predef._
+import io.gatling.core.Predef._
+
+import scala.concurrent.duration._
+import scala.util.Properties
+
+class ApiV1Simulation extends Simulation {
+
+  // Specify parameters for the run
+  val host = sys.env("OPENWHISK_HOST")
+  val connections = sys.env("CONNECTIONS").toInt
+  val seconds = Properties.envOrElse("SECONDS", "10").toInt.seconds
+
+  // Specify thresholds
+  val requestsPerSec = sys.env("REQUESTS_PER_SEC").toInt
+  val minimalRequestsPerSec = Properties.envOrElse("MIN_REQUESTS_PER_SEC", requestsPerSec.toString).toInt
 
 Review comment:
   Should this be:
   
   ```scala
   sys.env.getOrElse("MIN_REQUESTS_PER_SEC", requestsPerSec.toString).toInt
   ```
   
   No need for `Properties` here imo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services