You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/02/13 21:28:41 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #25448: Make `withDesiredBundleSizeBytes` methods public

Abacn commented on code in PR #25448:
URL: https://github.com/apache/beam/pull/25448#discussion_r1105030806


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java:
##########
@@ -806,9 +806,8 @@ abstract Builder<T> setFileExceptionHandler(
 
       abstract ReadFiles<T> build();
     }
-
-    @VisibleForTesting
-    ReadFiles<T> withDesiredBundleSizeBytes(long desiredBundleSizeBytes) {
+    

Review Comment:
   Thanks, seems it is now exposed to user, would you mind adding a brief javadoc? e.g. information in your PR description addressing when this may be useful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org